Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise < > as comparison operators in cond assign #8487

Merged
merged 2 commits into from Aug 8, 2020

Conversation

biinari
Copy link
Contributor

@biinari biinari commented Aug 8, 2020

Style/ConditionalAssignment cop detects most comparison operators: <=, >=, ==, !=, ===, <=>, =~, !~.

Add detection for < and >.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@biinari biinari force-pushed the fix/cond_assign_comparison_ops branch from b751f2e to 1e4c878 Compare August 8, 2020 03:47
'all assignment types' already checked for += and -= above.
@koic koic merged commit fad44bf into rubocop:master Aug 8, 2020
@koic
Copy link
Member

koic commented Aug 8, 2020

Thanks!

@biinari biinari deleted the fix/cond_assign_comparison_ops branch August 8, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants