Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocorrect for percent literal array with newlines #8481

Merged
merged 1 commit into from Aug 7, 2020

Conversation

biinari
Copy link
Contributor

@biinari biinari commented Aug 7, 2020

Fix line number when array element contains newline so that extra newlines
are not added to the result

Use expect_correction for embedded newline in percent literal array


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 7, 2020

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

Fix line number when array element contains newline so that extra newlines
are not added to the result

Use expect_correction for embedded newline in percent literal array
@biinari
Copy link
Contributor Author

biinari commented Aug 7, 2020

No problem. Rebased on master.

@koic koic merged commit db2b36e into rubocop:master Aug 7, 2020
@koic
Copy link
Member

koic commented Aug 7, 2020

Thank you!

@biinari biinari deleted the fix/word_array_newlines branch August 7, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants