Handle more matching methods in Lint/OutOfRangeRegexpRef #8464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneius
force-pushed
the
out_of_range_regexp_ref_more_methods
branch
5 times, most recently
from
f1873d0
to
aebb623
Compare
`when`, `grep`, `gsub`, `gsub!` `sub`, `sub!`, `[]`, `slice`, `slice!`, `scan`, `index`, `rindex`, `partition`, `rpartition`, `start_with?`, and `end_with?` can all be used to match regexps, so we should update the range of valid references when we encounter them.
eugeneius
force-pushed
the
out_of_range_regexp_ref_more_methods
branch
from
aebb623
to
fa1fc0b
Compare
|
Looks great, thanks for the PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to @marcandre's comment here: #8463 (comment)
when,grep,gsub,gsub!sub,sub!,[],slice,slice!scan,index,rindex,partition,rpartition,start_with?, andend_with?can all be used to match regexps and set last match global variables, so we should update the range of valid references when we encounter them.These were all of the relevant methods I could find from a quick grep of ruby/spec, although there could well be more.
Update: I read through the String class' docs and added several more methods.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.