Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid characters in Style/PercentLiteralDelimiters #8315

Merged
merged 1 commit into from Jul 13, 2020

Conversation

eugeneius
Copy link
Contributor

Previously this would crash with:

ArgumentError: invalid byte sequence in UTF-8
lib/rubocop/cop/style/percent_literal_delimiters.rb:105:in `match?'

I discovered this problem by running RuboCop on the real-world-rails repo, which includes the discourse repo:

https://github.com/discourse/discourse/blob/544a9865c6e5890f37e762292cbe5558db843dcf/spec/helpers/application_helper_spec.rb#L263


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Previously this would crash with:

    ArgumentError: invalid byte sequence in UTF-8
    lib/rubocop/cop/style/percent_literal_delimiters.rb:105:in `match?'
@koic koic merged commit c7b494b into rubocop:master Jul 13, 2020
@koic
Copy link
Member

koic commented Jul 13, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants