Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle major version requirements in Gemspec/RequiredRubyVersion #8310

Merged
merged 1 commit into from Jul 12, 2020

Conversation

eugeneius
Copy link
Contributor

It's possible to use required_ruby_version to allow all minor versions of a particular major version of Ruby:

spec.required_ruby_version = '~> 2'

Previously this would cause Gemspec/RequiredRubyVersion to crash with:

undefined method `[]' for nil:NilClass
lib/rubocop/cop/gemspec/required_ruby_version.rb:71:in `extract_ruby_version'

I discovered this problem by running RuboCop on the real-world-ruby-apps repo, which includes the htty gem:

https://github.com/htty/htty/blob/8db7a36d5dffcd6eef66580f052a86bcf1f3636b/htty.gemspec#L21

I've added docs and tests for the pessimistic operator, which otherwise works well.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

It's possible to use `required_ruby_version` to allow all minor versions
of a particular major version of Ruby:

    spec.required_ruby_version = '~> 2'

Previously this would cause `Gemspec/RequiredRubyVersion` to crash with:

    undefined method `[]' for nil:NilClass
    lib/rubocop/cop/gemspec/required_ruby_version.rb:71:in `extract_ruby_version'

I've added docs and tests for the pessimistic operator, which otherwise
works well.
@koic koic merged commit eda147e into rubocop:master Jul 12, 2020
@koic
Copy link
Member

koic commented Jul 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants