Support auto-correction for Style/IfUnlessModifierOfIfUnless
#8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supports auto-correction for `Style/IfUnlessModifierOfIfUnless`. From: ```ruby condition ? then_part : else_part unless external_condition ``` To: ```ruby unless external_condition condition ? then_part : else_part end ``` Branch indentation is left to `Layout/IndentationWidth` cop to keep the code simple.
koic
force-pushed
the
support_autocorrect_for_if_unless_modifier_of_if_unless
branch
from
a8afeba
to
bf8aaba
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports auto-correction for
Style/IfUnlessModifierOfIfUnless.From:
To:
Branch indentation is left to
Layout/IndentationWidthcop to keep the code simple.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.