Permit to specify TargetRubyVersion 2.8 #8213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, this PR will not be mergeable until rubocop/rubocop-ast#48 is released. I will close this PR and watch for the time. |
|
rubocop/rubocop-ast#48 (comment) has been released. I’ll take it later. |
koic
force-pushed
the
permit_to_specify_target_ruby_version_2_8
branch
from
6ca29a0
to
4a1c446
Compare
This PR permits to specify TargetRubyVersion 2.8. RuboCop AST supports Ruby 2.8 (3.0) with rubocop/rubocop-ast#48.
koic
force-pushed
the
permit_to_specify_target_ruby_version_2_8
branch
from
4a1c446
to
7e2e32e
Compare
|
I updated this PR and CI has succeeded. |
rrosenblum
approved these changes
Jun 26, 2020
marcandre
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR permits to specify TargetRubyVersion 2.8.
RuboCop AST supports Ruby 2.8 (3.0) with rubocop/rubocop-ast#48.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.