Support autocorrection for Lint/InterpolationCheck
#8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
support_autocorrect_for_lint_interpolation_check
branch
from
ebfdf94
to
73dcb7f
Compare
robotdana
reviewed
Jun 20, 2020
| def autocorrect(node) | ||
| lambda do |corrector| | ||
| corrector.replace(node.loc.begin, '"') | ||
| corrector.replace(node.loc.end, '"') |
There was a problem hiding this comment.
i think this will fail when correcting a string like '"#{}"'. it may also change the output of a string like %{\{#{}} (where what once was a string that equaled "{" it's now equal to "\{". These are guesses without running it though
There was a problem hiding this comment.
Sure! I updated to use %{...} if a offending string contains double quoted strings.
koic
force-pushed
the
support_autocorrect_for_lint_interpolation_check
branch
from
73dcb7f
to
6d988d7
Compare
This PR supports autocorrection for `Lint/InterpolationCheck` and marks it unsafe because autocorrected code is incompatible.
koic
force-pushed
the
support_autocorrect_for_lint_interpolation_check
branch
from
6d988d7
to
fba655f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports autocorrection for
Lint/InterpolationCheckand marks it unsafe because autocorrected code is incompatible.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.