Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Layout/EmptyLinesAroundAttributeAccessor #8150

Conversation

koic
Copy link
Member

@koic koic commented Jun 13, 2020

This PR fixes the following false positive for Layout/EmptyLinesAroundAttributeAccessor when using attribute accessors in if ... else branches.

if condition
  attr_reader :foo
else
  do_something
end
% bundle exec rubocop --only Layout/EmptyLinesAroundAttributeAccessor
(snip)
Inspecting 1 file
C

Offenses:

example.rb:2:3: C: Layout/EmptyLinesAroundAttributeAccessor: Add an
empty line after attribute accessor.
  attr_reader :foo
  ^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR fixes the following false positive for `Layout/EmptyLinesAroundAttributeAccessor`
when using attribute accessors in `if` ... `else` branches.

```ruby
if condition
  attr_reader :foo
else
  do_something
end
```

```console
% bundle exec rubocop --only Layout/EmptyLinesAroundAttributeAccessor
(snip)
Inspecting 1 file
C

Offenses:

example.rb:2:3: C: Layout/EmptyLinesAroundAttributeAccessor: Add an
empty line after attribute accessor.
  attr_reader :foo
  ^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected
```
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 14, 2020

Looks good!

@bbatsov bbatsov merged commit 928abea into rubocop:master Jun 14, 2020
@koic koic deleted the fix_a_false_positive_for_empty_lines_around_attribute_accessor branch June 14, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants