Fix false positives for Lint/ParenthesesAsGroupedExpression #8039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamilleDrapier
force-pushed
the
fix_auto_correct_parentheses_as_grouped_expression
branch
from
72093c4
to
af7e9e4
Compare
CamilleDrapier
changed the title
Lint/ParenthesesAsGroupedExpression
CamilleDrapier
changed the title
CamilleDrapier
changed the title
CamilleDrapier
force-pushed
the
fix_auto_correct_parentheses_as_grouped_expression
branch
2 times, most recently
from
d5f577a
to
b2bada9
Compare
koic
reviewed
Jul 1, 2020
koic
reviewed
Jul 1, 2020
CamilleDrapier
force-pushed
the
fix_auto_correct_parentheses_as_grouped_expression
branch
from
cae5dd2
to
6696334
Compare
This PR fixes the following false positive for `Lint/ParenthesesAsGroupedExpression` when an expression is followed by an operator ```ruby func (x) || y ``` when an expression is followed by a chain of functions ```ruby func (x).func.func.func.func.func ``` This PR adds some reproduction test
CamilleDrapier
force-pushed
the
fix_auto_correct_parentheses_as_grouped_expression
branch
from
6696334
to
5421042
Compare
|
Thanks! |
CamilleDrapier
deleted the
fix_auto_correct_parentheses_as_grouped_expression
branch
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 17, 2022
…edExpression` Fixes rubocop#10719 and follow up rubocop#8039. This PR fixes a false positive for `Lint/ParenthesesAsGroupedExpression` when using safe navigation operator.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following false positive for
Lint/ParenthesesAsGroupedExpressionThis PR adds some reproduction tests.
I was initially thinking of changing the auto-correct to produce things such as
func((x) || y)andfunc((x).func.func.func.func.func), but since we probably do not wanteq (x).to_ito become suddenlyeq((x).to_i)(#7909), I went with ignoring these pasterns. This is because the current auto-correct behavior breaks the code for these paterns. Please do tell me if we would prefer going in another direction 🙏I'm not very comfortable with these language nodes, so please treat this PR as an humble attempt 🙏
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.