Add EnforcedStyle for Style/DoubleNegation cop
#7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_enforced_style_for_style_double_negation
branch
from
03a16c3
to
496620b
Compare
bbatsov
requested changes
May 17, 2020
config/default.yml
Outdated
| @@ -2699,6 +2699,11 @@ Style/DoubleNegation: | |||
| StyleGuide: '#no-bang-bang' | |||
| Enabled: true | |||
| VersionAdded: '0.19' | |||
| VersionChanged: '1.0' | |||
There was a problem hiding this comment.
Make this 0.84, please. I'll cut one more release before 1.0 to make sure the rubocop-ast separation didn't cause problems.
config/default.yml
Outdated
| VersionChanged: '1.0' | ||
| EnforcedStyle: context | ||
| SupportedStyles: | ||
| - context |
There was a problem hiding this comment.
I think better names would be forbidden and allowed_in_returns or something along those lines.
There was a problem hiding this comment.
Or allowed_in_boolean_context?
There was a problem hiding this comment.
Thank you for suggesting a good name! I think allowed_in_returns is clear and straightforward!
|
The cop description should also be updated, as it currently pertains only to the |
koic
force-pushed
the
add_enforced_style_for_style_double_negation
branch
4 times, most recently
from
ee97052
to
3d8d795
Compare
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 17, 2020
Follow up to rubocop#7985 (comment). RuboCop 0.84 will be cut before RuboCop 1.0.
8 tasks
This PR adds `EnforcedStyle` option for `Style/DoubleNegation` cop, and `EnforcedStyle: allowed_in_boolean_context` by default based on rubocop#7833 survey. ```ruby # @example EnforcedStyle: allowed_in_boolean_context (default) # # good # def foo? # !!return_value # end # # @example EnforcedStyle: always # # bad # def foo? # !!return_value # end ``` Ruby will return the last evaluated value. This PR only supports simple contexts, such as the end of line value of method, and when using `return`. A complex contexts should also be supported, such as when branching with `if` and others in the future.
koic
force-pushed
the
add_enforced_style_for_style_double_negation
branch
from
3d8d795
to
9d19019
Compare
bbatsov
pushed a commit
that referenced
this pull request
May 17, 2020
Follow up to #7985 (comment). RuboCop 0.84 will be cut before RuboCop 1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
EnforcedStyleoption forStyle/DoubleNegationcop, andEnforcedStyle: contextby default based on #7833 survey.Ruby will return the last evaluated value.
This PR only supports simple contexts, such as the end of line value of method, and when using
return.A complex contexts should also be supported, such as when branching with
ifand others in the future.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.