Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change enforced style to conditionals for Style/AndOr #7959

Merged
merged 1 commit into from May 12, 2020

Conversation

koic
Copy link
Member

@koic koic commented May 12, 2020

This PR changes enforced style to conditionals for Style/AndOr cop.
It forward porting from rubocop/rubocop-rails#224.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR changes enforced style to `conditionals` for `Style/AndOr` cop.
It forward porting from rubocop/rubocop-rails#224.
@bbatsov bbatsov merged commit 9731d67 into rubocop:master May 12, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented May 12, 2020

Thanks!

@koic koic deleted the change_enforced_style_to_conditionals branch May 12, 2020 18:07
@zverok
Copy link
Contributor

zverok commented May 13, 2020

Wonderful :) Seems it is about time to review rubocop/ruby-style-guide#730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants