Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rakefile (lowercase) to default config #7951

Merged
merged 1 commit into from May 11, 2020
Merged

add rakefile (lowercase) to default config #7951

merged 1 commit into from May 11, 2020

Conversation

jethrodaniel
Copy link
Contributor

@jethrodaniel jethrodaniel commented May 11, 2020

We should also support rakefile when looking for Ruby files to
process.

As of rake-13.0.1

# rake/lib/rake/application.rb
DEFAULT_RAKEFILES = [
  "rakefile",
  "Rakefile",
  "rakefile.rb",
  "Rakefile.rb"
].freeze

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member

koic commented May 11, 2020

Can you add a chengelog entry and update spec/rubocop/target_finder_spec.rb?
e.g. #7895

@jethrodaniel
Copy link
Contributor Author

Had no idea about spec/rubocop/target_finder_spec.rb, thanks.

I just forgot the change-log.

We should also support `rakefile` when looking for Ruby files to
process.

As of rake-13.0.1

```
# rake/lib/rake/application.rb
DEFAULT_RAKEFILES = [
  "rakefile",
  "Rakefile",
  "rakefile.rb",
  "Rakefile.rb"
].freeze
```
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koic koic merged commit 21a864f into rubocop:master May 11, 2020
@jethrodaniel jethrodaniel deleted the rakefile branch May 11, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants