Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark unsafe for Style/OptionalArguments cop #7948

Merged
merged 1 commit into from May 10, 2020

Conversation

koic
Copy link
Member

@koic koic commented May 10, 2020

This PR marks unsafe for Style/OptionalArguments cop because changing method signature makes interface incompatible.
The incompatibility between good example and bad example shows that.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR marks unsafe for `Style/OptionalArguments` cop because
changing method signature makes interface incompatible.
The incompatibility between good example and bad example shows that.
@bbatsov bbatsov merged commit ee2d393 into rubocop:master May 10, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented May 10, 2020

Thanks!

@koic koic deleted the mark_unsafe_style_optional_arguments branch May 10, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants