Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support autocorrection for Layout/ConditionPosition #7925

Conversation

koic
Copy link
Member

@koic koic commented May 3, 2020

This PR supports autocorrection for Layout/ConditionPosition.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Collaborator

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on fire! Great work!

This PR supports autocorrection for `Layout/ConditionPosition`.
@koic koic force-pushed the support_autocorrection_for_layout_condition_position] branch from 0a5f89f to 8fd210a Compare May 10, 2020 12:04
@koic koic merged commit 42a607f into rubocop:master May 10, 2020
@koic koic deleted the support_autocorrection_for_layout_condition_position] branch May 10, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants