Support autocorrection for Lint/AmbiguousOperator
#7918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
support_autocorrect_for_ambiguous_operator
branch
from
fc22427
to
e2ae212
Compare
jonas054
requested changes
May 1, 2020
| return offense_node if offense_node | ||
| end | ||
|
|
||
| processed_source.ast.each_node(:send).find do |send_node| |
There was a problem hiding this comment.
You can use the local variable ast here.
| context 'with parentheses around the operator' do | ||
| it 'does not register an offense' do | ||
| expect_no_offenses(<<~RUBY) | ||
| do_something(-42) |
There was a problem hiding this comment.
Should be +42 since the example is within the context "with + unary operator in the first argument".
koic
force-pushed
the
support_autocorrect_for_ambiguous_operator
branch
from
e2ae212
to
bc65f33
Compare
|
Thanks for your review! I updated this PR. |
jonas054
approved these changes
May 1, 2020
This PR supports autocorrection for `Lint/AmbiguousOperator`.
koic
force-pushed
the
support_autocorrect_for_ambiguous_operator
branch
from
bc65f33
to
1acc2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports autocorrection for
Lint/AmbiguousOperator.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.