Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support autocorrection for Lint/AmbiguousRegexpLiteral #7916

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 28, 2020

This PR supports autocorrection for Lint/AmbiguousRegexpLiteral.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR supports autocorrection for `Lint/AmbiguousRegexpLiteral`.
@koic koic force-pushed the support_autocorrect_for_ambiguous_regexp_literal branch from 48899f7 to cf02f40 Compare April 28, 2020 10:18
@bbatsov bbatsov merged commit 7db331e into rubocop:master Apr 29, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 29, 2020

Great work!

@koic koic deleted the support_autocorrect_for_ambiguous_regexp_literal branch April 29, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants