Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Lint/LiteralAsCondition #7913

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 27, 2020

This PR fixes a false positive for Lint/LiteralAsCondition when using true literal in while and similar cases.

while true is a known idiom. Normally loop is used, OTOH while true may be selected for speeding up. Users use these methods depending on use case. That was introduced as part of RubyKaigi 2019.
https://rubykaigi.org/2019/presentations/ktou.html


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 29, 2020

I'd mention those exempt cases in the docs.

@koic koic force-pushed the false_positive_for_lint_literal_as_condition branch from 8829ee0 to 27b4a5c Compare April 29, 2020 07:27
@koic
Copy link
Member Author

koic commented Apr 29, 2020

Sure. I added a typical example case and a brief note for itself.

@koic koic force-pushed the false_positive_for_lint_literal_as_condition branch from 27b4a5c to e0d8fe4 Compare May 7, 2020 09:20
This PR fixes a false positive for `Lint/LiteralAsCondition`
when using `true` literal in `while` and similar cases.

`while true` is a known idiom.

Normally `loop` is used, OTOH `while true` may be selected for
speeding up. Users use these methods depending on use case.
That was introduced as part of RubyKaigi 2019.
https://rubykaigi.org/2019/presentations/ktou.html
@koic koic force-pushed the false_positive_for_lint_literal_as_condition branch from e0d8fe4 to 4244b24 Compare May 9, 2020 05:21
@koic koic merged commit db6d1d0 into rubocop:master May 9, 2020
@koic koic deleted the false_positive_for_lint_literal_as_condition branch May 9, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants