Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support autocorrection for Lint/ParenthesesAsGroupedExpression #7910

Conversation

koic
Copy link
Member

@koic koic commented Apr 26, 2020

Follow up to #7909.

This PR supports autocorrection for Lint/ParenthesesAsGroupedExpression.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member Author

koic commented Apr 26, 2020

This PR will be ready to be reviewed after #7909 is merged.

@koic koic force-pushed the support_autocorrect_for_parentheses_as_grouped_expression branch from cd4260c to 0b4750d Compare May 9, 2020 05:17
@koic koic marked this pull request as ready for review May 9, 2020 05:22
Follow up to rubocop#7909.

This PR supports autocorrection for `Lint/ParenthesesAsGroupedExpression`.
@koic koic force-pushed the support_autocorrect_for_parentheses_as_grouped_expression branch from 0b4750d to 6793645 Compare May 10, 2020 11:27
@koic koic merged commit c1e55dd into rubocop:master May 10, 2020
@koic koic deleted the support_autocorrect_for_parentheses_as_grouped_expression branch May 10, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants