Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for hash transform methods #7903

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 23, 2020

Follow up to rubocop/rubocop-rails#239.

This PR fixes an incorrect autocorrect for Style/HashTransformKeys and Style/HashTransformValues cops when line break before to_h method.

In the future, duplicate code in RuboCop Rails may be removed, making it dependent on RuboCop core code. It centralizes the resolution of problems.

cc @diogoosorio


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Collaborator

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Follow up to rubocop/rubocop-rails#239.

This PR fixes an incorrect autocorrect for `Style/HashTransformKeys` and
`Style/HashTransformValues` cops when line break before `to_h` method.

In the future, duplicate code in RuboCop Rails may be removed,
making it dependent on RuboCop core code. It centralizes the resolution
of problems.

Co-authored-by: Diogo Osório <diogo.osorio@marleyspoon.com>
@koic koic force-pushed the fix_incorrect_autocorrect_for_hash_transform_methods branch from 9b0a927 to 41eae31 Compare April 24, 2020 05:04
@koic koic merged commit ac7e4e3 into rubocop:master Apr 24, 2020
@koic koic deleted the fix_incorrect_autocorrect_for_hash_transform_methods branch April 24, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants