Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .simplecov to rubocop default include list #7895

Merged
merged 1 commit into from Apr 20, 2020

Conversation

robotdana
Copy link
Contributor

This list looks fairly comprehensive, so lets add .simplecov the ruby config file for simplecov gem

https://github.com/colszowka/simplecov#using-simplecov-for-centralized-config

@koic
Copy link
Member

koic commented Apr 20, 2020

Can you add the chengelog entry and update the following testcase?

diff --git a/spec/rubocop/target_finder_spec.rb b/spec/rubocop/target_finder_spec.rb
index f21311654..64ccc1187 100644
--- a/spec/rubocop/target_finder_spec.rb
+++ b/spec/rubocop/target_finder_spec.rb
@@ -36,6 +36,7 @@ RSpec.describe RuboCop::TargetFinder, :isolated_environment do

   RUBY_FILENAMES = %w[.irbrc
                       .pryrc
+                      .simplecov
                       Appraisals
                       Berksfile
                       Brewfile

Ref: #7715

This list looks fairly comprehensive, so lets add
.simplecov the ruby config file for simplecov gem

https://github.com/colszowka/simplecov#using-simplecov-for-centralized-config
@bbatsov bbatsov merged commit 079fa63 into rubocop:master Apr 20, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants