Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/CaseEquality when AllowOnConstant is true #7882

Merged
merged 1 commit into from Apr 17, 2020

Conversation

rafaelfranca
Copy link
Contributor

@rafaelfranca rafaelfranca commented Apr 16, 2020

When the method receiver is implicit it was failing with a NoMethodError in nil error.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [ x Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

When the method receiver is implicit it was failing with a NoMethodError
in `nil` error.
@koic koic merged commit 1740db0 into rubocop:master Apr 17, 2020
@koic
Copy link
Member

koic commented Apr 17, 2020

Thank you!

@rafaelfranca rafaelfranca deleted the rm-fix-allow-constant branch April 17, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants