Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Migration/DepartmentName cop by default #7723

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 17, 2020

This PR enables Migration/DepartmentName cop by default.

The cop has been added at #7385.

The cop will promote the migration to adding department name to cop name.
Omitting a department name will not be supported in the future, so enabling this cop by default will facilitate the migration.

The PR was inspired by the following issue:

RuboCop no longer supports ambiguous cop names (those without a department).

#7717 (comment)


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR enables `Migration/DepartmentName` cop by default.

The cop has been added at rubocop#7385.

The cop will promote the migration to adding department name to cop name.
Omitting a department name will not be supported in the future,
so enabling this cop by default will facilitate the migration.

The PR was inspired by the following issue:

> RuboCop no longer supports ambiguous cop names (those without a department).

rubocop#7717 (comment)
@bbatsov bbatsov merged commit 75f5b98 into rubocop:master Feb 17, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 17, 2020

Thanks!

@koic koic deleted the enable_migration_department_name_by_default branch February 17, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants