Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Steepfile to default Include list #7715

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented Feb 14, 2020

Steep 0.12.0 has introduced Steepfile.
See https://github.com/soutaro/steep/blob/v0.12.0/CHANGELOG.md#0120-2020-02-11.

We can write the Ruby DSL in Steepfile. For example:

target :app do
  check "lib"
  signature "sig"

  library "set", "pathname"
end

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@ybiquitous ybiquitous marked this pull request as ready for review February 14, 2020 13:10
@ybiquitous
Copy link
Contributor Author

I'm not sure whether I should update CHANGELOG.md. 😓

@koic
Copy link
Member

koic commented Feb 14, 2020

Yeah. Can you add a changelog entry?

@ybiquitous
Copy link
Contributor Author

ybiquitous commented Feb 14, 2020

@koic Thanks for your reply. I've changed. Is it OK? 08f37d381c9d5ff60734cb826302157a17415014

@koic
Copy link
Member

koic commented Feb 14, 2020

This looks good to me. Can you squash your commits into one?

@ybiquitous
Copy link
Contributor Author

Yes! I've done it.

@koic koic merged commit f857af5 into rubocop:master Feb 14, 2020
@koic
Copy link
Member

koic commented Feb 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants