Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line length autocorrect for blocks #7659

Merged
merged 1 commit into from Feb 4, 2020

Conversation

maxh
Copy link
Contributor

@maxh maxh commented Jan 18, 2020

Shortens long lines by inserting a line break into blocks like this:

# original
foo.bar { |baz| batbatbatbatbatbatbatbat(baz) }

# auto-corrected after this PR
foo.bar { |baz|
batbatbatbatbatbatbatbat(baz) }

# auto-corrected after other block alignment cops run
# (just one example -- final output depends on config)
foo.bar do |baz|
  batbatbatbatbatbatbatbat(baz)
end

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

#
# - ParameterAlignment
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I alpha ordered this list.

@bbatsov bbatsov merged commit ac65140 into rubocop:master Feb 4, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 4, 2020

Thanks!

@maxh maxh deleted the maxh/more-autocorrect branch February 16, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants