allow paremeter name pp for pretty_print
#7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
approved these changes
Jan 15, 2020
|
For more information: |
|
Can you add the change log entry? The following is an example (The cop name and allowed name in the changelog entry is different). |
masarakki
changed the title
pp for pretty_print
|
added |
koic
reviewed
Jan 25, 2020
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ | |||
| * [#7636](https://github.com/rubocop-hq/rubocop/issues/7636): Remove `console` from `Lint/Debugger` to prevent false positives. ([@gsamokovarov][]) | |||
| * [#7641](https://github.com/rubocop-hq/rubocop/issues/7641): **(Breaking)** Remove `Style/BracesAroundHashParameters` cop. ([@pocke][]) | |||
| * Add the method name to highlight area of `Layout/EmptyLineBetweenDefs` to help provide more context. ([@rrosenblum][]) | |||
| * [#7652](https://github.com/rubocop-hq/rubocop/pull/7652): Allow parameter name `pp` for overriding `pretty_print`. ([@masarakki][]) | |||
There was a problem hiding this comment.
I think it will be clearer if the cop name is specified. e.g:
-* [#7652](https://github.com/rubocop-hq/rubocop/pull/7652): Allow parameter name `pp` for overriding `pretty_print`. ([@masarakki][])
+* [#7652](https://github.com/rubocop-hq/rubocop/pull/7652): Allow `pp` to allowed names of `Naming/MethodParameterName` cop in default config. ([@masarakki][])
|
updated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppis standard parameter name forPrettyPrintBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.