Fix edge case in omit_parentheses style of Style/MethodCallWithArgsParentheses
#7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
omit-parentheses-rhs-of-operators
branch
from
b8b59e2
to
bd072df
Compare
|
This looks good to me. Can you rebase with the latest master branch? |
gsamokovarov
force-pushed
the
omit-parentheses-rhs-of-operators
branch
from
bd072df
to
a12b152
Compare
…ArgsParentheses`
Before this change:
```ruby
foo(a) || bar(b) do
^^^ Omit parentheses for method calls with arguments.
pass
end
```
This resulted in a `SyntaxError`, if corrected. The check for a call
with logical operator did not take into account that the parent of a send node with a block is the block node itself.
After this change, the code below is lawful:
```ruby
foo(a) || bar(b) do
pass
end
```
gsamokovarov
force-pushed
the
omit-parentheses-rhs-of-operators
branch
from
a12b152
to
c7d6d76
Compare
|
Of course, I just rebased it. |
koic
approved these changes
Jan 9, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change:
This resulted in a
SyntaxErrorif corrected. The check for a callwith a logical operator did not take into account that the parent of a
send node with a block is the block node itself.
After this change, the code below is lawful: