Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SafeMode module #7502

Merged
merged 1 commit into from Nov 12, 2019
Merged

Conversation

koic
Copy link
Member

@koic koic commented Nov 12, 2019

Follow up #7341

Therefore, the following milestones were planned. This plan does not
remove SafeMode module immediately.

  • RuboCop 0.75 ... Presents an alternative API via ConfigObsolete module
  • RuboCop 0.76 ... Remove SafeMode

This is probably a better way, as it is best to offer an alternative API
in the 3rd party module.

RuboCop 0.76 has been released. This PR removes SafeMode module.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up rubocop#7341

> Therefore, the following milestones were planned. This plan does not
> remove SafeMode module immediately.
>
> - RuboCop 0.75 ... Presents an alternative API via ConfigObsolete module
> - RuboCop 0.76 ... Remove SafeMode
>
> This is probably a better way, as it is best to offer an alternative API
> in the 3rd party module.

RuboCop 0.76 has been released. This PR removes `SafeMode` module.
@bbatsov bbatsov merged commit 35ea8a5 into rubocop:master Nov 12, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 12, 2019

Thanks!

@koic koic deleted the remove_safe_mode_module branch November 12, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants