Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllowIfModifier option to Style/IfInsideElse cop #7150

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 17, 2019

This PR adds AllowIfModifier option to Style/IfInsideElse cop.

This new option is based on rails/rails repo use case shown at the following URL.
rails/rails#36495.

This option works as follows.

AllowIfModifier: false (default)

AllowIfModifier is false by default. So breaking change will not happen.

# bad
if condition_a
  action_a
else
  action_b if condition_b
end

AllowIfModifier: true

It allows the following case when AllowIfModifier is true.

# good
if condition_a
  action_a
else
  action_b if condition_b
end

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR adds `AllowIfModifier` option to `Style/IfInsideElse` cop.

This new option is based on rails/rails repo use case shown at the following URL.
rails/rails#36495.

This option works as follows.

### AllowIfModifier: false (default)

`AllowIfModifier` is false by default. So breaking change will not happen.

```ruby
# bad
if condition_a
  action_a
else
  action_b if condition_b
end
```

### AllowIfModifier: true

It allows the following case when `AllowIfModifier` is true.

```ruby
# good
if condition_a
  action_a
else
  action_b if condition_b
end
```
@koic koic force-pushed the add_allow_if_modifier_option_to_if_inside_else branch from 9ae4107 to 1074df6 Compare June 17, 2019 06:11
@bbatsov bbatsov merged commit 905331f into rubocop:master Jun 18, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 18, 2019

The proposed change is fine by me. Thanks!

@koic koic deleted the add_allow_if_modifier_option_to_if_inside_else branch June 18, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants