Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow safe-navigation in ternary conditions without parenthesis #7121

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Allow safe-navigation in ternary conditions without parenthesis #7121

merged 1 commit into from
Jun 25, 2019

Conversation

timon
Copy link
Contributor

@timon timon commented Jun 10, 2019

When enforced style is require_parenthesis_if_complex, the following
code is considered valid:

  foo = bar.baz? ? a : b

But safe navigation operator produces an offence.
This commit makes the following code also acceptable:

  foo = bar&.baz ? a : b

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member

koic commented Jun 11, 2019

It is difficult to define simple condition and complex condition. It may be better for offense to occur because foo&.bar is a conditional expression similar to foo && bar.
But I think this PR is valid because foo[:bar] has no offense. It is also shown as simple condition in the test cases as a symbolic syntax.

When enforced style is `require_parenthesis_if_complex`, the following
code is considered valid:

```ruby
  foo = bar.baz? ? a : b
```

This commit makes the following code also acceptable:

```ruby
  foo = bar&.baz ? a : b
```
@bbatsov bbatsov merged commit 239e2b6 into rubocop:master Jun 25, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 25, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants