Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Naming/RescuedExceptionsVariableName autocorrection #6998

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Darhazer
Copy link
Member

Follow up on #6994, this PR adds renaming of the variable references inside the resbody


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@Darhazer Darhazer force-pushed the improve-rescued-exception-variable-autocorrect branch from f685971 to 0f06a36 Compare April 29, 2019 21:22
@bbatsov bbatsov merged commit ab3f564 into master Apr 29, 2019
@bbatsov bbatsov deleted the improve-rescued-exception-variable-autocorrect branch April 29, 2019 22:00
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 29, 2019

Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants