Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add always_braces to Style/BlockDelimiters #6973

Merged
merged 1 commit into from Apr 29, 2019

Conversation

iGEL
Copy link
Contributor

@iGEL iGEL commented Apr 26, 2019

This style always prefers braces over do...end.

This style always prefers braces over do...end. Similar to double quotes, some developers don't want to bother with changing the style when adding or removing a line or debate, whether a blocks like

date = Timecop.freeze(1.year.ago) { format_date(Time.now) }
customer = Timecop.freeze(1.year.ago) { create(:customer) }

are functional or procedual.

I didn't add a always_do_end style, as I don't think that someone wants to enforce this in all situation (chaining, ...).


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@iGEL iGEL force-pushed the always_braces_for_blocks branch 2 times, most recently from 7885bf6 to f780c3f Compare April 26, 2019 14:44
This style always prefers braces over do...end. Similar to double
quotes, some developers don't want to bother with changing the style
when adding or removing a line or debate, whether a blocks like

```ruby
date = Timecop.freeze(1.year.ago) { format_date(Time.now) }
customer = Timecop.freeze(1.year.ago) { create(:customer) }
```

are functional or procedual.

I didn't add a always_do_end style, as I don't think that someone wants
to enforce this in all situation (chaining, ...).

Sponsored by @BillFront
@bbatsov bbatsov merged commit 87a6ec4 into rubocop:master Apr 29, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 29, 2019

Thanks!

@iGEL iGEL deleted the always_braces_for_blocks branch April 29, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants