Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6950] Mark Rails/TimeZone as unsafe #6966

Merged
merged 1 commit into from Apr 25, 2019

Conversation

vfonic
Copy link
Contributor

@vfonic vfonic commented Apr 25, 2019

Note: This is the first time I'm sending a PR and marking a cop as unsafe. Please check if I missed anything!

Thanks!


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

config/default.yml Outdated Show resolved Hide resolved
@vfonic vfonic force-pushed the mark-rails-time-zone-unsafe branch from 18c7591 to b58cdad Compare April 25, 2019 08:21
@bbatsov bbatsov merged commit 38765b1 into rubocop:master Apr 25, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 25, 2019

Thanks!

@vfonic vfonic deleted the mark-rails-time-zone-unsafe branch April 25, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants