Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rails/ReflectionClassName to use string interpolation #6946

Merged
merged 1 commit into from Apr 18, 2019

Conversation

r7kamura
Copy link
Contributor

Like this:

has_many :accounts, class_name: "#{prefix}Account"

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@r7kamura r7kamura force-pushed the feature/rails-reflection-dstr branch from 2c1bc53 to d6eb151 Compare April 17, 2019 18:21
@bbatsov bbatsov merged commit b638bb8 into rubocop:master Apr 18, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 18, 2019

Thanks!

@r7kamura r7kamura deleted the feature/rails-reflection-dstr branch April 18, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants