Fix false negative for Layout/SpaceAroundBlockParameters #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
fix-for-Layout/SpaceAroundBlockParameters
branch
from
d372514
to
cee94d9
Compare
koic
reviewed
Mar 2, 2019
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### Bug fixes | |||
|
|
|||
| * [#6699](https://github.com/rubocop-hq/rubocop/issues/6699): Fix infinite loop for `Layout/IndentationWidth` and `Layout/IndentationConsistency` when bad modifier indentation before good method definition. ([@koic][]) | |||
| * [#6797](https://github.com/rubocop-hq/rubocop/pull/6797): Fix false negative for Layout/SpaceAroundBlockParameters. ([@pocke][]) | |||
There was a problem hiding this comment.
Can you explain in more detail about the false negative corrected?
There was a problem hiding this comment.
Sure 👍 I'll update it.
There was a problem hiding this comment.
I updated the description of the changelog. Thanks!
pocke
force-pushed
the
fix-for-Layout/SpaceAroundBlockParameters
branch
from
cee94d9
to
67791d7
Compare
koic
approved these changes
Mar 2, 2019
pocke
force-pushed
the
fix-for-Layout/SpaceAroundBlockParameters
branch
from
67791d7
to
9612547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cop is not aware of parens in block parameter. This pull request fixes this problem.
Example
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.