Allow parens for optional keyword value calls in Style/MethodCallWithArgsParentheses #6765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
omit-parentheses-kwargs
branch
from
ddc7382
to
9cf9999
Compare
|
This looks good 🌟 Would you add the CHANGELOG entry? |
Before:
```ruby
def foo(bar: baz(42))
^^^^ Omit parentheses for method calls with arguments.
end
```
After:
```ruby
def foo(bar: baz(42))
end
```
```
gsamokovarov
force-pushed
the
omit-parentheses-kwargs
branch
from
9cf9999
to
4f1449b
Compare
|
@koic, thanks for the reminder. Added the changelog entry, the change should be good now. |
|
Thank you @gsamokovarov! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet-another-edge-case for the
omit_parenthesesstyle.Before:
After: