Allow parens for calls in range literals (Style/MethodCallWithArgsParentheses) #6763
Conversation
| expect_no_offenses(<<-RUBY) | ||
| 1..limit(n) | ||
| RUBY | ||
| end |
There was a problem hiding this comment.
Looks good! On the other hand, there is also erange in the similar case :-)
1...limit(n)Would you please add along with the CHANGELOG entry?
There was a problem hiding this comment.
Oh, didn't know that. Thanks for the catch!
gsamokovarov
force-pushed
the
omit-parentheses-in-range-literals
branch
3 times, most recently
from
4611c7b
to
f2216da
Compare
| @@ -259,13 +259,16 @@ def legitimate_call_with_parentheses?(node) | |||
| allowed_chained_call_with_parentheses?(node) | |||
| end | |||
|
|
|||
| # rubocop:disable Metrics/CyclomaticComplexity | |||
There was a problem hiding this comment.
The whole omit_parentheses style is based around the many edge-cases where we actually do need the parentheses. I have tried to cater to the Metrics/CyclomaticComplexity until now, but the extra helpers I introduce to hide the conditions blow up the line length cop. I think the code will be clearer if we don't measure the cyclomatic complexity for this whole cop and eventually inline the helpers where they are used.
There was a problem hiding this comment.
Introduction of range_type? meaning both irange_type? and erange_type? is proposed.
#6126 (comment)
We will be able to remove the disabling cop comment when replaced by this proposal . So I think this is fine.
There was a problem hiding this comment.
#6773 will remove the disabling cop comment.
Before:
```ruby
1..limit(n)
^^^ Omit parentheses for method calls with arguments.
```
After:
```ruby
1..limit(n)
```
馃憣
gsamokovarov
force-pushed
the
omit-parentheses-in-range-literals
branch
from
f2216da
to
9fc434e
Compare
|
Thanks! |
With the style of
omit_parenthesesin theStyle/MethodCallWithArgsParenthesescop, we got:Before:
After:
馃憣