Mark Style/ModuleFunction as unsafe autocorrect #6613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
force-pushed
the
unsafe-module-function
branch
2 times, most recently
from
26563f3
to
25cf531
Compare
dduugg
force-pushed
the
unsafe-module-function
branch
2 times, most recently
from
5794dd9
to
dabd3fb
Compare
|
I've resolved the merge conflicts and bumped the |
|
Could you also move the |
dduugg
force-pushed
the
unsafe-module-function
branch
from
dabd3fb
to
7064991
Compare
|
@Drenmi done! |
dduugg
force-pushed
the
unsafe-module-function
branch
from
7064991
to
7d28eff
Compare
|
@Drenmi I've rebased this forward in hopes of getting it into the next release. Would love to clear this from my open PRs, please let me know if there's anything I can do to nudge it along. Thanks! |
koic
approved these changes
Feb 16, 2019
dduugg
force-pushed
the
unsafe-module-function
branch
from
7d28eff
to
bc0b8b4
Compare
|
Thanks @koic, i've resolved the conflict and re-pushed. |
|
Thank you @dduugg! |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks the Style/ModuleFunction cop as both
Autocorrect: falseandSafeAutocorrect: falsein the default configuration. This is consistent with the documentation ("These offenses are not auto-corrected since there are different implications to each approach."), although I have slightly reworded it here.The autocorrect was intentionally omitted when the cop was made configurable (see https://github.com/rubocop-hq/rubocop/pull/3173/files#diff-58bfe8eeff6579e001f02da76228d98fR26) because the styles are not equivalent. See the discussion at rubocop/ruby-style-guide#556 for more details.
I have not added tests b/c this is a configuration change, but happy to do so if you have any suggestions.
Thanks for your consideration.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.