Fix exit status when rubocop is interrupted #6436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to resume the work I started on #5808, but I noticed a small issue with the status code rubocop has when interrupted. If you type Ctrl-C while rubocop is running, it will have an exit status of "1", which in rubocop's domain means "offenses were detected". However, this is not accurate since one may interrupt rubocop without any offenses having yet been detected (for example, because it will take too long to run).
So I changed the status code in this situation to be 130, which is a common practice for scripts. See for example https://stackoverflow.com/a/40484670/143243.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
rake default
. It executes all tests and RuboCop for itself, and generates the documentation.