New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #6262] Optimise --auto-gen-config when Metrics/LineLength cop is disabled #6343
[Fix #6262] Optimise --auto-gen-config when Metrics/LineLength cop is disabled #6343
Conversation
e6f9a8e
to
0f2340e
Compare
@tom-lord Looks good, but please follow your own suggestion and present a different message when the cop is disabled. |
f6cfec2
to
a3da4c6
Compare
[BUMP] I have made further changes, as discussed above with @jonas054. |
Please update |
You need to add a link to your GitHub account at the bottom of the file. |
Ahh right, yeah. I figured it was just some CircleCI glitch since my final commit would "obviously" not break any tests. The error message is quite clear, but unfortunately the output is so long that you need to download the full log to even see it! I might submit a separate PR to flatten that output into something legible, for the next person. |
957390c
to
5276232
Compare
👍 Looks good now! |
5276232
to
9549b68
Compare
9549b68
to
f7fe3b5
Compare
Is there anything holding this up from being merged? I've just had to rebase again, as the changelog diff became stale. |
Resolves #6262
With this change, running
rubocop --auto-gen-config
will now skip "Phase 1 of 2: run Metrics/LineLength cop", if theMetrics/LineLength
cop is disabled.This makes the todo file generation faster, when line length checks are disabled.