[Fix #9175] Fix status for offenses that are not correctable. #9190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a few things:
1) Calling `add_offense` or `add_offense { |corrector| # don't auto-correct }` should be handled the same way. An empty corrector is now replaced by `nil`.
2) Tweaks how the status is handled. Status `:uncorrected` is reserved for cases where there is a corrector but it is not applied.
3) Old style cops' `auto_correct` method is now called even when run without auto-correction. This way we can know if they can auto-correct or not. It also simplifies logic.
I should have done 3) during my refactor (I don't see how it could be incompatible)
8 tasks
|
Looks good to me. |
dvandersluis
approved these changes
Dec 8, 2020
8 tasks
dvandersluis
added a commit
to dvandersluis/rubocop
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a few things:
add_offenseoradd_offense { |corrector| # don't auto-correct }should be handled the same way. An empty corrector is now replaced bynil.:uncorrectedis reserved for cases where there is a corrector but it is not applied.auto_correctmethod is now called even when run without auto-correction. This way we can know if they can auto-correct or not. It also simplifies logic.I should have done 3) during my refactor (I don't see how it could be incompatible)