Show extension cop versions when using --verbose-version option
#8908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_extension_versions_when_using_verbose_version
branch
2 times, most recently
from
f1f1d4f
to
e289be0
Compare
koic
changed the title
--verbose_version option--verbose-version option
koic
force-pushed
the
add_extension_versions_when_using_verbose_version
branch
2 times, most recently
from
f206bc0
to
ef3d9e8
Compare
## Summary This PR shows extension cop versions when using `--verbose-version` option. Before: ```console % rubocop -V 0.93.1 (using Parser 2.7.2.0, rubocop-ast 0.8.0, running on ruby 2.7.2 x86_64-darwin19) ``` After: ```console % rubocop -V 0.93.1 (using Parser 2.7.2.0, rubocop-ast 0.8.0, running on ruby 2.7.2 x86_64-darwin19) - rubocop-performance 1.8.1 - rubocop-rspec 1.43.2 ``` This information is not shown in `rubocop -v` as it is needed in the bug report, first. ## More Information It shows extension cop versions named rubocop-feature (e.g. rubocop-performance, rubocop-rspec). Extention names separated by two or more, such as rubocop-feature-foo, are not supported by this PR. First of all, this is aimed at supporting the extension cop managed by RuboCop Headquarters. This feature searches for version constant in two ways: - RuboCop core version style (e.g. `RuboCop::Performance::Version::STRING`) - `bundle gem` version style (e.g. `RuboCop::Rake::VERSION`) This enriches the information when reporting bugs from users. It was inspired by RSpec. Thank you. ```console % bundle exec rspec --version RSpec 3.9 - rspec-core 3.9.3 - rspec-expectations 3.9.2 - rspec-mocks 3.9.1 - rspec-support 3.9.3 ```
koic
force-pushed
the
add_extension_versions_when_using_verbose_version
branch
from
ef3d9e8
to
96d2809
Compare
koic
added a commit
to koic/rubocop
that referenced
this pull request
Oct 21, 2020
Follow rubocop#8908. This PR fixes the following error when ocurring cop error. ```console % bundle exec rubocop (snip) 1 file inspected, no offenses detected 1 error occurred: An error occurred while Layout/ExtraSpacing cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/43/example.rb. undefined method `config_store' for nil:NilClass /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/version.rb:35:in `extension_versions' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/version.rb:21:in `version' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli/command/execute_runner.rb:62:in `display_error_summary' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli/command/execute_runner.rb:27:in `execute_runner' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cli/command/execute_runner.rb:17:in `run' ``` It suppresses unexpected `undefined method `config_store' for nil:NilClass`.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR shows extension cop versions when using
--verbose-versionoption.Before:
After:
This information is not shown in
rubocop -vas it is needed in the bug report, first.More Information
It shows extension cop versions named rubocop-feature (e.g. rubocop-performance, rubocop-rspec).
Extention names separated by two or more, such as rubocop-feature-foo, are not supported by this PR. First of all, this is aimed at supporting the extension cop managed by RuboCop Headquarters.
This feature searches for version constant in two ways:
RuboCop::Performance::Version::STRING)bundle gemversion style (e.g.RuboCop::Rake::VERSION)This enriches the information when reporting bugs from users.
It was inspired by RSpec. Thank you.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.