[Fix #8875] Fix incorrect autocorrect for Style/ClassEqualityComparison
#8876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_incorrect_autocorrect_for_class_equality_comparison
branch
2 times, most recently
from
cc1ae79
to
821c5e9
Compare
bbatsov
approved these changes
Oct 9, 2020
…Comparison` Fixes rubocop#8875. Fix an incorrect auto-correct for `Style/ClassEqualityComparison` when comparing string class name.
koic
force-pushed
the
fix_incorrect_autocorrect_for_class_equality_comparison
branch
from
821c5e9
to
ec93d26
Compare
koic
deleted the
fix_incorrect_autocorrect_for_class_equality_comparison
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8875.
This PR fixes an incorrect auto-correct for
Style/ClassEqualityComparisonwhen comparing string class name, and it tweaks the offense message.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.