[Fix #8862] Fix an error for Lint/AmbiguousRegexpLiteral
#8863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_error_for_ambiguous_regexp_literal
branch
from
b0fbd93
to
0bc327d
Compare
8 tasks
bbatsov
reviewed
Oct 8, 2020
| @@ -61,6 +61,8 @@ def find_offense_node(node, regexp_receiver) | |||
| end | |||
|
|
|||
| def method_chain_to_regexp_receiver?(node) | |||
| return false unless node.parent.receiver | |||
There was a problem hiding this comment.
It seem node.parent is not repeated 3 times in the code. Perhaps a local variable is in order.
koic
force-pushed
the
fix_error_for_ambiguous_regexp_literal
branch
from
0bc327d
to
4bf83d2
Compare
bbatsov
approved these changes
Oct 9, 2020
Fixes rubocop#8862. This PR fixes an error for `Lint/AmbiguousRegexpLiteral` when using regexp without method calls in nested structure.
koic
force-pushed
the
fix_error_for_ambiguous_regexp_literal
branch
from
4bf83d2
to
e36f120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8862.
This PR fixes an error for
Lint/AmbiguousRegexpLiteralwhen using regexp without method calls in nested structure.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.