Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8855] Fix an error when using only access modifier #8856

Merged
merged 1 commit into from Oct 8, 2020

Conversation

koic
Copy link
Member

@koic koic commented Oct 6, 2020

Fixes #8855.

This PR fixes an error for Layout/EmptyLinesAroundAccessModifier and Style/AccessModifierDeclarations when using only access modifier.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_an_error_for_two_cops branch from b2ae458 to 6468ef1 Compare October 6, 2020 07:50
Fixes rubocop#8855.

This PR fixes an error for `Layout/EmptyLinesAroundAccessModifier` and
`Style/AccessModifierDeclarations` when using only access modifier.
@koic koic force-pushed the fix_an_error_for_two_cops branch from 6468ef1 to 415d3e8 Compare October 6, 2020 08:28
@koic koic merged commit e563130 into rubocop:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

top level public occurs errors
1 participant