Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when expect_corrections runs into an infinite loop #8779

Merged
merged 1 commit into from Sep 25, 2020

Conversation

dvandersluis
Copy link
Member

The message for InfiniteCorrectionLoop was changed in #8701, but it now crashes if expect_corrections in a spec causes an infinite loop:

Failure/Error:
  root_cause = offenses_by_iteration[loop_start..-1]
               .map { |x| x.map(&:cop_name).uniq.join(', ') }
               .join(' -> ')

NoMethodError:
  undefined method `map' for nil:NilClass
# ./lib/rubocop/runner.rb:18:in `initialize'
# ./lib/rubocop/rspec/expect_offense.rb:160:in `new'
# ./lib/rubocop/rspec/expect_offense.rb:160:in `block in expect_correction'
# ./lib/rubocop/rspec/expect_offense.rb:150:in `loop'
# ./lib/rubocop/rspec/expect_offense.rb:150:in `expect_correction'

This fixes that crash by capturing the offenses in expect_offenses and passing them into RuboCop::Runner::InfiniteCorrectionLoop.new.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov bbatsov merged commit da5b737 into rubocop:master Sep 25, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 25, 2020

Thanks!

@dvandersluis dvandersluis deleted the fix/expect-offense-loop branch January 18, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants