Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read TargetRubyVersion from gemspec required_ruby_version if not specified #8761

Closed
donv opened this issue Sep 22, 2020 · 3 comments · Fixed by #8885
Closed

Read TargetRubyVersion from gemspec required_ruby_version if not specified #8761

donv opened this issue Sep 22, 2020 · 3 comments · Fixed by #8885
Labels
enhancement good first issue Easy task, suitable for newcomers to the project

Comments

@donv
Copy link

donv commented Sep 22, 2020

Is your feature request related to a problem? Please describe.

Gemspec/RequiredRubyVersion enforces that gemspec.required_ruby_version is set and then complains that it differs from TargetRubyVersion in .rubocop.yml even if it is not specified in .rubocop.yml.

Having to specify TargetRubyVersion in .rubocop.yml in addition to gemspec.required_ruby_version duplicates the information.

Describe the solution you'd like

If TargetRubyVersion is not specified in .rubocop.yml it should be read from gemspec.required_ruby_version if present.
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 25, 2020

Fine by me.

@bbatsov bbatsov added enhancement good first issue Easy task, suitable for newcomers to the project labels Sep 25, 2020
@HeroProtagonist
Copy link
Contributor

👋 I am going to take a stab at this one

@HeroProtagonist HeroProtagonist mentioned this issue Oct 12, 2020
Merged
8 tasks
@HeroProtagonist
Copy link
Contributor

PR submitted 👍

HeroProtagonist added a commit to HeroProtagonist/rubocop that referenced this issue Nov 8, 2020
@HeroProtagonist
[Fix rubocop#8761] Add GemspecFile class and specs
e8af386
HeroProtagonist added a commit to HeroProtagonist/rubocop that referenced this issue Nov 8, 2020
@HeroProtagonist
[Fix rubocop#8761] Update docs
ada7ba3
HeroProtagonist added a commit to HeroProtagonist/rubocop that referenced this issue Nov 8, 2020
@HeroProtagonist
[Fix rubocop#8761] Update changelog entry
460e770
bbatsov pushed a commit that referenced this issue Nov 8, 2020
@HeroProtagonist
[Fix #8761] Read required_ruby_version from gemspec file if it exis…
406d0e3 
…ts (#8885)
cetinajero added a commit to cetinajero/rubocop that referenced this issue Nov 12, 2020
@cetinajero
Fix required_ruby_version issue when using Gem::Requirement
a451545 
This fixes an issue when the `required_ruby_version` uses `Gem::Requirement` to define the Ruby version.

e.g.

```
s.required_ruby_version = Gem::Requirement.new('< 3.0.0')
```

Related to rubocop#8761
@cetinajero cetinajero mentioned this issue Nov 12, 2020
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Nov 13, 2020
@cetinajero
Fix required_ruby_version issue when using Gem::Requirement (#9037)
9e83b37 
This fixes an issue when the `required_ruby_version` uses `Gem::Requirement` to define the Ruby version.

e.g.

```
s.required_ruby_version = Gem::Requirement.new('< 3.0.0')
```

Related to #8761
ashkulz added a commit to prontolabs/pronto-rubocop that referenced this issue Feb 18, 2021
@ashkulz
fix compatibility with RuboCop 1.3.0 and later
ae2faf8 
As a result of rubocop/rubocop#8761
the TargetRubyVersion is read from the gemspec and due to a bug
rubocop/rubocop#9482 this blocks
the upgrade to support later RuboCop versions -- so let's specify
2.4 as a workaround.
@ashkulz ashkulz mentioned this issue Feb 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Easy task, suitable for newcomers to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #8761] Read required_ruby_version from gemspec file if it exists HeroProtagonist/rubocop
3 participants
@donv @bbatsov @HeroProtagonist