New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable autocorrection for Style/DateTime
#8738
Merged
bbatsov
merged 2 commits into
rubocop:master
from
dvandersluis:style-date-time-autocorrection
Sep 25, 2020
Merged
Enable autocorrection for Style/DateTime
#8738
bbatsov
merged 2 commits into
rubocop:master
from
dvandersluis:style-date-time-autocorrection
Sep 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
force-pushed
the
style-date-time-autocorrection
branch
3 times, most recently
from
September 16, 2020 16:05
1803f5a
to
d15f7ac
Compare
marcandre
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
koic
reviewed
Sep 16, 2020
dvandersluis
force-pushed
the
style-date-time-autocorrection
branch
from
September 16, 2020 16:42
d15f7ac
to
b8900a1
Compare
dvandersluis
force-pushed
the
style-date-time-autocorrection
branch
from
September 21, 2020 17:35
b8900a1
to
af27183
Compare
@koic @marcandre would this be okay to merge now? |
The next release may be 0.91.1 (bug fix) and I'm not sure about next release version. I would like to merge when the next release is decided to be 0.92. |
@koic makes perfect sense! |
dvandersluis
force-pushed
the
style-date-time-autocorrection
branch
from
September 21, 2020 18:05
af27183
to
2fe8471
Compare
koic
approved these changes
Sep 21, 2020
dvandersluis
force-pushed
the
style-date-time-autocorrection
branch
from
September 22, 2020 16:19
2fe8471
to
27b2120
Compare
I'll cut the new release later today. |
dvandersluis
force-pushed
the
style-date-time-autocorrection
branch
from
September 23, 2020 17:05
27b2120
to
21adc21
Compare
dvandersluis
force-pushed
the
style-date-time-autocorrection
branch
from
September 24, 2020 14:29
21adc21
to
5b6934f
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style/DateTime
did not have autocorrection enabled, so I added it to replaceDateTime
withTime
. I have marked this as unsafe because we are not checking if the date being used is historic or not (unless astart
parameter is passed in, such as iniso8601
, in which case an offense isn't registered anyways).I did not enable autocorrection for
to_datetime
because the message just states to not use it.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.