Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Lint/MissingSuper [See #8376] #8480

Merged
merged 1 commit into from Aug 7, 2020
Merged

Conversation

marcandre
Copy link
Contributor

No description provided.

@ruanltbg
Copy link

ruanltbg commented Aug 6, 2020

Thank you for the hard/fast work.

@fatkodima
Copy link
Contributor

Seems like there are another 3 ones https://ruby-doc.org/core-2.7.1/BasicObject.html#method-i-singleton_method_added
Sorry, forgot about them also.

@marcandre
Copy link
Contributor Author

Seems like there are another 3 ones https://ruby-doc.org/core-2.7.1/BasicObject.html#method-i-singleton_method_added

I never realize those existed. I can't think of a reason for their existence either, as def singleton_class.method_added should have the same effect. I added them to the list 👍

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@bbatsov bbatsov merged commit 9d5cbe6 into rubocop:master Aug 7, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 7, 2020

Indeed!

@marcandre marcandre deleted the includedandal branch August 7, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants