Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #8108] Disregard whitespace lines in HeredocIndentation #8109

Merged
merged 1 commit into from Jun 7, 2020
Merged

[Fix #8108] Disregard whitespace lines in HeredocIndentation #8109

merged 1 commit into from Jun 7, 2020

Conversation

jonas054
Copy link
Collaborator

@jonas054 jonas054 commented Jun 7, 2020

Empty lines were already excluded for calculation of indentation in Layout/HeredocIndentation. We need to do the same thing for lines consisting only of whitespace.

@jonas054
[Fix rubocop#8108] Disregard whitespace lines in HeredocIndentation
32de264 
Empty lines were already excluded for calculation of indentation in
Layout/HeredocIndentation. We need to do the same thing for lines
consisting only of whitespace.
@koic koic merged commit dc757dd into rubocop:master Jun 7, 2020
@koic
Copy link
Member

koic commented Jun 7, 2020

Thanks!

@jonas054 jonas054 deleted the 8108_heredoc_trailing_ws_infinite_loop branch June 7, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonas054 @koic